Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doclint): support lists in comments #1492

Merged
merged 1 commit into from
Mar 23, 2020
Merged

fix(doclint): support lists in comments #1492

merged 1 commit into from
Mar 23, 2020

Conversation

JoelEinbinder
Copy link
Contributor

Adds logging comments to the doclint tests, and adds a new one with a bulleted list in a comment. Lists can only be used in comments where extra properties would be unexpected.

@JoelEinbinder JoelEinbinder requested a review from dgozman March 23, 2020 21:17
@dgozman
Copy link
Contributor

dgozman commented Mar 23, 2020

I don't know how we are going to use it, but looks good 😄

@JoelEinbinder
Copy link
Contributor Author

We already use it in frame.uncheck for example.

@JoelEinbinder JoelEinbinder merged commit 1a25a4e into microsoft:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoelEinbinder @dgozman